I have a jsp page that displays records in a dynamic table with each record
having its own checkbox called select. When a check box is selected and the
form is submitted it goes to another page called delete.jsp which is shown
below. The code works but at the moment it will only delete one record. I would
like to be able to be able to use delete to remove all the checked items I
have selected but I cannot seem to get it to delete more than one record at a time.
I tested the page and printed out the string called selected and it printed the
string "1,2,3" which are the ID values that i selected. Does anyone have any
ideas where i am going wrong or maybe you know a better way that i could
delete more than one at a time.

<%  
 
	String deleteArray[] = request.getParameterValues("select");
	String selected="";
 
	if (deleteArray != null) {
		
		// multiple items selected
		for (int i = 0; i < deleteArray.length; i++) {
 
		selected += deleteArray[i];
 
		if( i < deleteArray.length -1) {
			selected += ",";
			}
	 } 
		
}
 
Driver DriverdeleteTopics = (Driver)Class.forName(MM_connQuestion_DRIVER).newInstance();
Connection ConndeleteTopics = DriverManager.getConnection(MM_connQuestion_STRING,MM_connQuestion_USERNAME,MM_connQuestion_PASSWORD);
PreparedStatement deleteTopics = ConndeleteTopics.prepareStatement("DELETE FROM Question.topic  WHERE Topic_ID IN ('" + selected + "')");
deleteTopics.executeUpdate(); 
%>

Any help would be much appreciated

Thanks

 

 

I changed the code to the following to see if it would make a difference but it will still
only seem to delete one record when i make check multiple boxes. Can someone please tell me what the problem seems to be as i cannot seem to work it out.

<%  
 
	String deleteArray[] = request.getParameterValues("select");
	String selected="";
 
	if (deleteArray != null) {
		
		if(deleteArray.length == 1) {
 
			// Only one item is selected
			selected = deleteArray[0];
 
	 } else {
 
		// multiple items selected
		for (int i = 0; i < deleteArray.length; i++) {
 
		selected += deleteArray[i];
 
		if( i < deleteArray.length -1) {
			selected += ",";
}
 
 
}
 
}
 
 
}
 
%>
<% 
Driver DriverdeleteTopics = (Driver)Class.forName(MM_connQuestion_DRIVER).newInstance();
Connection ConndeleteTopics = DriverManager.getConnection(MM_connQuestion_STRING,MM_connQuestion_USERNAME,MM_connQuestion_PASSWORD);
PreparedStatement deleteTopics = ConndeleteTopics.prepareStatement("DELETE FROM Question.topic  WHERE Topic_ID IN ('" + selected + "')");
deleteTopics.executeUpdate(); 
%>

Thanks

 

 

Try printing out the SQL statement you are about to execute:

ie:

String sql = "DELETE FROM Question.topic  WHERE Topic_ID IN ('" + selected + "')"
System.out.println("About to execute " + sql);

Check your database to see if the rows are actually deleted or not.

How does the JSP page of checkboxes get generated? Maybe the rows are being deleted from the database, but you need to update/refresh a java list elsewhere in memory as well?

Hope this helps,
evnafets

 

 

I printed the query and it looks like this

com.mysql.jdbc.ServerPreparedStatement[1] - DELETE FROM Question.topic WHERE Topic_ID IN ('2,5')
 

the row in the table on the jsp page that sets the values of the checkbox looks like this.

<td><input name="select" type="checkbox" id="select" value="<%=(((topicRecordset_data = topicRecordset.getObject("Topic_ID"))==null ||topicRecordset.wasNull())?"":topicRecordset_data)%>" /></td>

is it something to do with adding another "," on the end or is there something I am not doing something properly?

 

 

I added a comma onto the end of the selected string to see if it would make any difference but it still seems to only delete one record at a time. Can anyone tell me wot is wrong with my code or my SQL string as i can not seem to see any problems.

Thanks

 

 

try this one

DELETE FROM Question.topic WHERE Topic_ID IN (" selected ")

Remove the Single Quote in the IN Clause.....

 

 

If ur TOPIC_ID is numeric, then u dont need single quotes. Try raghav_132's.

If not it should do like this:

DELETE FROM Question.topic WHERE Topic_ID IN ('2','5')

change ur 'for' loop to append single quotes also in your 'selected' string

 

 

Yes ! I agree to dummy-girl. She sounds quit logical.
As ur string values must be in single quotes and numeric values without quotes.
If Topic_ID is numeric (as it sounds like numeric) than u should not append single quotes.

try this out...
i hope it will help u..

regards
amit

 

 

Thanks for your help guys, really appreciate it! managed to get it working now so it will delete multiple records.

There was one other question that i was wondering about. At the moment i have a submit button at the bottom of the page and it looks a bit untidy so i would like to be able to sumit the delete form using an image on that is outside the form on the left hand side of the page. I looked into it and addedd some javascript that looks like this.

function submitform()
{
  document.deleteForm.submit();
}

and then i put this in the image tag

<a href="javascript:;" onclick="submitform()"><img src="../img/delete_topic.png" width="175" height="35" border="0" />

i though this would submit the form but it does not appear to do so. Doews anyone hagve any ideas about how to do this? im not sure but i think i need to use a hidden field somewhere but i am not sure what would need to go in it. Any help would be much appreciated.

Thanks

xxx

 

 

y not just

<input type="image" onclick="this.form.submit()" src="../img/delete_topic.png" width="175" height="35" />

hth

goofy